fix(security): sanitize terminal output to block ANSI/OSC injection#1
Open
Skilledcamman wants to merge 1 commit intoKitchenEngineer1332:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a terminal escape injection issue where untrusted page text was rendered directly in the terminal UI.
Issue
Untrusted remote content could include ANSI/OSC control sequences. Rendering those bytes in terminal output can trigger terminal-side actions (such as clipboard manipulation, deceptive hyperlinks, or UI spoofing).
What changed
In
src/renderer.rs, this PR addssanitize_terminal_text()and applies it to all untrusted display paths:Why
Because the vulnerability occurs at terminal render time. Sanitizing at render sinks ensures control sequences are stripped immediately before display, preventing escape-sequence execution regardless of where the untrusted text originated.